From 5e1ec86e21e72094a034cedf5dd013f9b01ad0cc Mon Sep 17 00:00:00 2001 From: Martin Monperrus Date: Mon, 3 Sep 2018 20:42:54 +0200 Subject: [PATCH] fix a bug for techreport in IEEE's style JanosBibliographyStyle --- bibtexbrowser-test.php | 6 ++++++ bibtexbrowser.php | 12 +++++++----- 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/bibtexbrowser-test.php b/bibtexbrowser-test.php index be4d567..ce9e8d6 100755 --- a/bibtexbrowser-test.php +++ b/bibtexbrowser-test.php @@ -758,9 +758,15 @@ class BTBTest extends PHPUnit_Framework_TestCase { $this->assertEquals(4,count($btb->bibdb['arXiv-1807.05030']->getRawAuthors())); $this->assertEquals(4,count($btb->bibdb['arXiv-1807.05030']->getFormattedAuthorsArray())); $this->assertEquals("Oscar Luis Vera-Pérez, Benjamin Danglot, Martin Monperrus and Benoit Baudry",$btb->bibdb['arXiv-1807.05030']->getAuthor()); + + bibtexbrowser_configure('BIBTEXBROWSER_LINK_STYLE','nothing'); + bibtexbrowser_configure('BIBLIOGRAPHYSTYLE','JanosBibliographyStyle'); + $this->assertEquals("Oscar Luis Vera-Pérez, Benjamin Danglot, Martin Monperrus and Benoit Baudry, \"A Comprehensive Study of Pseudo-tested Methods\", Technical report, arXiv 1807.05030, 2018.\n ",strip_tags($btb->bibdb['arXiv-1807.05030']->toHTML())); + } + } // end class @copy('bibtexbrowser.local.php.bak','bibtexbrowser.local.php'); diff --git a/bibtexbrowser.php b/bibtexbrowser.php index fc3c999..663070a 100755 --- a/bibtexbrowser.php +++ b/bibtexbrowser.php @@ -2413,11 +2413,11 @@ function JanosBibliographyStyle($bibentry) { $publisher = 'Master\'s thesis, '.$bibentry->getField(SCHOOL); } if ($type=="techreport") { - $publisher = 'Technical report'; + $publisher = 'Technical report, '; + $publisher .=$bibentry->getField("institution"); if ($bibentry->hasField("number")) { - $publisher = $bibentry->getField("number"); + $publisher .= ' '.$bibentry->getField("number"); } - $publisher .=', '.$bibentry->getField("institution"); } if ($bibentry->hasField("publisher")) { $publisher = $bibentry->getField("publisher"); @@ -2425,8 +2425,10 @@ function JanosBibliographyStyle($bibentry) { if ($publisher!='') $entry[] = $publisher; - if ($bibentry->hasField('volume')) $entry[] = "vol. ".$bibentry->getField("volume"); - if ($bibentry->hasField('number')) $entry[] = 'no. '.$bibentry->getField("number"); + if ($type=="article") { + if ($bibentry->hasField('volume')) $entry[] = "vol. ".$bibentry->getField("volume"); + if ($bibentry->hasField('number')) $entry[] = 'no. '.$bibentry->getField("number"); + } if ($bibentry->hasField('address')) $entry[] = $bibentry->getField("address");