fm/zrd-bibtexbrowser
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Tidied up generation mechanism for [pdf], [doi] links etc.

Browse Source 
Removed duplicate code that existed inside and outside of get*Link() functions.
Added option BIBTEXBROWSER_LINKS_IN_NEW_WINDOW. It is used instead of BIBTEXBROWSER_BIB_IN_NEW_WINDOW for external links (everything but [bibtex]).
This commit is contained in:
Markus Jochim
2014-12-04 22:41:34 +01:00
committed by Martin Monperrus
parent c2b330bb7c
commit dbc28d4448
1 changed files with 24 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bibtexbrowser.php
+24 -29
View File
@@ -100,6 +100,9 @@ function bibtexbrowser_configure($key, $value) {
// do we add [gsid] links (Google Scholar)? // do we add [gsid] links (Google Scholar)?
@define('BIBTEXBROWSER_GSID_LINKS',true); @define('BIBTEXBROWSER_GSID_LINKS',true);
// should pdf, doi, url, gsid links be opened in a new window?
@define('BIBTEXBROWSER_LINKS_IN_NEW_WINDOW',true);
// should authors be linked to [none/homepage/resultpage] // should authors be linked to [none/homepage/resultpage]
// none: nothing // none: nothing
// their homepage if defined as @strings // their homepage if defined as @strings
@@ -1109,11 +1112,21 @@ class BibEntry {
if ($altlabel==NULL) { $altlabel=$bibfield; } if ($altlabel==NULL) { $altlabel=$bibfield; }
$str = $this->getIconOrTxt($altlabel,$iconurl); $str = $this->getIconOrTxt($altlabel,$iconurl);
if ($this->hasField($bibfield)) { if ($this->hasField($bibfield)) {
return '<a'.(BIBTEXBROWSER_BIB_IN_NEW_WINDOW?' target="_blank" ':'').' href="'.$this->getField($bibfield).'">'.$str.'</a>'; return '<a'.(BIBTEXBROWSER_LINKS_IN_NEW_WINDOW?' target="_blank" ':'').' href="'.$this->getField($bibfield).'">'.$str.'</a>';
} }
return ''; return '';
} }
/** returns a "[bib]" link */
function getBibLink($iconurl=NULL) {
$bibstr = $this->getIconOrTxt('bibtex',$iconurl);
$href = 'href="'.$this->getURL().'"';
// we add biburl and title to be able to retrieve this important information
// using Xpath expressions on the XHTML source
$link = "<a".(BIBTEXBROWSER_BIB_IN_NEW_WINDOW?' target="_blank" ':'')." class=\"biburl\" title=\"".$this->getKey()."\" {$href}>$bibstr</a>";
return $link;
}
/** returns a "[pdf]" link if relevant. modified to exploit the new method, while keeping backward compatibility */ /** returns a "[pdf]" link if relevant. modified to exploit the new method, while keeping backward compatibility */
function getUrlLink($iconurl = NULL, $label = 'pdf') { function getUrlLink($iconurl = NULL, $label = 'pdf') {
if ($this->hasField('url')) { if ($this->hasField('url')) {
@@ -1129,34 +1142,22 @@ class BibEntry {
} }
} }
/** returns a "[bib]" link if relevant */
function getBibLink($iconurl=NULL) {
if (BIBTEXBROWSER_BIBTEX_LINKS) {
$bibstr = $this->getIconOrTxt('bibtex',$iconurl);
$href = 'href="'.$this->getURL().'"';
$link = "<a".(BIBTEXBROWSER_BIB_IN_NEW_WINDOW?' target="_blank" ':'')." class=\"biburl\" title=\"".$this->getKey()."\" {$href}>$bibstr</a>";
return $link;
} else {
return '';
}
}
/** DOI are a special kind of links, where the url depends on the doi */ /** DOI are a special kind of links, where the url depends on the doi */
function getDoiLink($iconurl=NULL) { function getDoiLink($iconurl=NULL) {
$str = $this->getIconOrTxt('doi',$iconurl); $str = $this->getIconOrTxt('doi',$iconurl);
if (BIBTEXBROWSER_DOI_LINKS && $this->hasField('doi')) { if ($this->hasField('doi')) {
return '<a href="http://dx.doi.org/'.$this->getField('doi').'">'.$str.'</a>'; return '<a'.(BIBTEXBROWSER_LINKS_IN_NEW_WINDOW?' target="_blank" ':'').' href="http://dx.doi.org/'.$this->getField('doi').'">'.$str.'</a>';
} }
return ''; return '';
} }
/** GS are a special kind of links, where the url depends on the google scholar id */ /** GS (Google Scholar) are a special kind of links, where the url depends on the google scholar id */
function getGSLink($iconurl=NULL) { function getGSLink($iconurl=NULL) {
$str = $this->getIconOrTxt('cites',$iconurl); $str = $this->getIconOrTxt('cites',$iconurl);
// Google Scholar ID if ($this->hasField('gsid')) {
if (BIBTEXBROWSER_GSID_LINKS && $this->hasField('gsid')) { return ' <a'.(BIBTEXBROWSER_LINKS_IN_NEW_WINDOW?' target="_blank" ':'').' href="http://scholar.google.com/scholar?cites='.$this->getField("gsid").'">'.$str.'</a>';
return ' <a href="http://scholar.google.com/scholar?cites='.$this->getField("gsid").'">'.$str.'</a>';
} }
return ''; return '';
} }
@@ -1678,28 +1679,22 @@ function get_HTML_tag_for_layout() {
* e.g. [bibtex] [doi][pdf] * e.g. [bibtex] [doi][pdf]
*/ */
function bib2links_default(&$bibentry) { function bib2links_default(&$bibentry) {
$href = 'href="'.$bibentry->getURL().'"';
$str = '<span class="bibmenu">'; $str = '<span class="bibmenu">';
if (BIBTEXBROWSER_BIBTEX_LINKS) { if (BIBTEXBROWSER_BIBTEX_LINKS) {
// we add biburl and title to be able to retrieve this important information $str .= ' '.$bibentry->getBibLink();
// using Xpath expressions on the XHTML source
$str .= "<a".(BIBTEXBROWSER_BIB_IN_NEW_WINDOW?' target="_blank" ':'')." class=\"biburl\" title=\"".$bibentry->getKey()."\" {$href}>[bibtex]</a>";
} }
if (BIBTEXBROWSER_PDF_LINKS) { if (BIBTEXBROWSER_PDF_LINKS) {
// returns an empty string if no url present
$str .= ' '.$bibentry->getUrlLink(); $str .= ' '.$bibentry->getUrlLink();
} }
if (BIBTEXBROWSER_DOI_LINKS && $bibentry->hasField('doi')) { if (BIBTEXBROWSER_DOI_LINKS) {
$str .= ' <a href="http://dx.doi.org/'.$bibentry->getField("doi").'">[doi]</a>'; $str .= ' '.$bibentry->getDoiLink();
} }
// Google Scholar ID if (BIBTEXBROWSER_GSID_LINKS) {
if (BIBTEXBROWSER_GSID_LINKS && $bibentry->hasField('gsid')) { $str .= ' '.$bibentry->getGSLink();
$str .= ' <a href="http://scholar.google.com/scholar?cites='.$bibentry->getField("gsid").'">[cites]</a>';
} }
$str .= '</span>'; $str .= '</span>';