Browse Source

fixed comment. more consistent test (unknown extension)

pull/96/head
Jens Kober 6 years ago
parent
commit
ab2af1332b
  1. 4
      bibtexbrowser-test.php
  2. 2
      bibtexbrowser.php

4
bibtexbrowser-test.php

@ -339,7 +339,7 @@ class BTBTest extends PHPUnit_Framework_TestCase {
function test_link_configuration() { function test_link_configuration() {
bibtexbrowser_configure('BIBTEXBROWSER_LINKS_TARGET','_self'); bibtexbrowser_configure('BIBTEXBROWSER_LINKS_TARGET','_self');
$test_data = fopen('php://memory','x+'); $test_data = fopen('php://memory','x+');
fwrite($test_data, "@book{aKey,pdf={myarticle.pdf}}\n@book{bKey,url={myarticle.pdf}}\n@book{cKey,url={myarticle.htm}}\n"
fwrite($test_data, "@book{aKey,pdf={myarticle.pdf}}\n@book{bKey,url={myarticle.pdf}}\n@book{cKey,url={myarticle.xyz}}\n"
); );
fseek($test_data,0); fseek($test_data,0);
$btb = new BibDataBase(); $btb = new BibDataBase();
@ -352,7 +352,7 @@ class BTBTest extends PHPUnit_Framework_TestCase {
$second_entry=$btb->bibdb[array_keys($btb->bibdb)[1]]; $second_entry=$btb->bibdb[array_keys($btb->bibdb)[1]];
$this->assertEquals('<a href="myarticle.pdf">[pdf]</a>',$second_entry->getPdfLink()); $this->assertEquals('<a href="myarticle.pdf">[pdf]</a>',$second_entry->getPdfLink());
$third_entry=$btb->bibdb[array_keys($btb->bibdb)[2]]; $third_entry=$btb->bibdb[array_keys($btb->bibdb)[2]];
$this->assertEquals('<a href="myarticle.htm">[url]</a>',$third_entry->getPdfLink());
$this->assertEquals('<a href="myarticle.xyz">[url]</a>',$third_entry->getPdfLink());
} }
// see https://github.com/monperrus/bibtexbrowser/pull/14 // see https://github.com/monperrus/bibtexbrowser/pull/14

2
bibtexbrowser.php

@ -1340,7 +1340,7 @@ class BibEntry {
return ""; return "";
} }
/** See description of 'getPdfLink'
/** See description of 'getUrlLink'
*/ */
function getAndRenameLink($bibfield, $iconurl=NULL) { function getAndRenameLink($bibfield, $iconurl=NULL) {
$extension = strtolower(pathinfo(parse_url($this->getField($bibfield),PHP_URL_PATH),PATHINFO_EXTENSION)); $extension = strtolower(pathinfo(parse_url($this->getField($bibfield),PHP_URL_PATH),PATHINFO_EXTENSION));

Loading…
Cancel
Save