refactor into heredoc for readability

8 years ago · c2156dcb79
2 changed files with 41 additions and 19 deletions
--- a/.gitignore
+++ b/.gitignore
@ -0,0 +1,17 @@
+# OS generated files #
+######################
+.DS_Store
+.DS_Store?
+._*
+.Spotlight-V100
+.Trashes
+ehthumbs.db
+Thumbs.db
+
+# emacs
+*~
+
+
+bibtexbrowser*.dat
+public/
+vendor/
--- a/bibtexbrowser.php
+++ b/bibtexbrowser.php
@ -4740,23 +4740,28 @@ class Dispatcher {
    exit;
  }

-  function frameset() {    ?>
-
-
-    <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Frameset//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-frameset.dtd">
-    <html  xmlns="http://www.w3.org/1999/xhtml">
-    <head>
-    <meta name="generator" content="bibtexbrowser v__GITHUB__" />
-    <meta http-equiv="Content-Type" content="text/html; charset=<?php echo OUTPUT_ENCODING ?>"/>
-    <title>You are browsing <?php echo htmlentities($_GET[Q_FILE], ENT_QUOTES); ?> with bibtexbrowser</title>
-    </head>
-    <frameset cols="15%,*">
-    <frame name="menu" src="<?php echo '?'.Q_FILE.'='. urlencode($_GET[Q_FILE]).'&amp;menu'; ?>" />
-    <frame name="main" src="<?php echo '?'.Q_FILE.'='. urlencode($_GET[Q_FILE]).'&amp;'.BIBTEXBROWSER_DEFAULT_FRAME?>" />
-    </frameset>
-    </html>
-
-    <?php
+  function frameset() {
+    $OUTPUT_ENCODING = OUTPUT_ENCODING;
+    $BIBTEXBROWSER_DEFAULT_FRAME = BIBTEXBROWSER_DEFAULT_FRAME;
+    $bibFilename = htmlentities($_GET[Q_FILE], ENT_QUOTES);
+    $uriFrameMenu = '?'.Q_FILE.'='. urlencode($_GET[Q_FILE]).'&amp;menu';
+    $uriFrameMain = '?'.Q_FILE.'='. urlencode($_GET[Q_FILE]).'&amp;'.BIBTEXBROWSER_DEFAULT_FRAME;
+    //
+print <<<HTML
+<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Frameset//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-frameset.dtd">
+<html  xmlns="http://www.w3.org/1999/xhtml">
+<head>
+<meta name="generator" content="bibtexbrowser v__GITHUB__" />
+<meta http-equiv="Content-Type" content="text/html; charset=$OUTPUT_ENCODING"/>
+<title>You are browsing $bibFilename with bibtexbrowser</title>
+</head>
+<frameset cols="15%,*">
+<frame name="menu" src="$uriFrameMenu" />
+<frame name="main" src="$uriFrameMain" />
+</frameset>
+</html>
+HTML;
+    //
    return 'END_DISPATCH';
 }